From ce57c09b664fd1584355bd234974badd41d64a18 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Tue, 9 Sep 2014 12:35:31 -0700 Subject: [PATCH] Fix tests on windows --- src/cargo/ops/cargo_package.rs | 5 +++-- tests/test_cargo_package.rs | 9 ++++----- tests/test_cargo_upload.rs | 7 ++++--- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/cargo/ops/cargo_package.rs b/src/cargo/ops/cargo_package.rs index 3bf28597c..40b3ddcf7 100644 --- a/src/cargo/ops/cargo_package.rs +++ b/src/cargo/ops/cargo_package.rs @@ -1,5 +1,6 @@ use std::io::File; use std::io::fs::PathExtensions; +use std::path; use tar::Archive; use flate2::{GzBuilder, BestCompression}; @@ -52,8 +53,8 @@ fn tar(pkg: &Package, src: &PathSource, shell: &mut MultiShell, try!(shell.verbose(|shell| { shell.status("Archiving", relative.as_slice()) })); - let path = format!("{}-{}/{}", pkg.get_name(), - pkg.get_version(), relative); + let path = format!("{}-{}{}{}", pkg.get_name(), + pkg.get_version(), path::SEP, relative); try!(ar.append(path.as_slice(), &mut file).chain_error(|| { internal(format!("could not archive source file `{}`", relative)) })); diff --git a/tests/test_cargo_package.rs b/tests/test_cargo_package.rs index 882113cb4..de6a28049 100644 --- a/tests/test_cargo_package.rs +++ b/tests/test_cargo_package.rs @@ -40,10 +40,9 @@ test!(simple { let ar = Archive::new(MemReader::new(contents)); for f in ar.files().assert() { let f = f.assert(); - match f.filename().unwrap() { - "foo-0.0.1/Cargo.toml" | - "foo-0.0.1/src/main.rs" => {} - s => fail!("unexpected file: {}", s), - } + let fname = f.filename_bytes(); + assert!(fname == Path::new("foo-0.0.1/Cargo.toml").as_vec() || + fname == Path::new("foo-0.0.1/src/main.rs").as_vec(), + "unexpected filename: {}", f.filename()) } }) diff --git a/tests/test_cargo_upload.rs b/tests/test_cargo_upload.rs index a450960a5..a813ef080 100644 --- a/tests/test_cargo_upload.rs +++ b/tests/test_cargo_upload.rs @@ -61,9 +61,10 @@ test!(simple { let ar = Archive::new(inner); for file in ar.files().unwrap() { let file = file.unwrap(); - assert!(file.filename() == Some("foo-0.0.1/Cargo.toml") || - file.filename() == Some("foo-0.0.1/src/main.rs"), - "bad filename: {}", file.filename()); + let fname = file.filename_bytes(); + assert!(fname == Path::new("foo-0.0.1/Cargo.toml").as_vec() || + fname == Path::new("foo-0.0.1/src/main.rs").as_vec(), + "unexpected filename: {}", file.filename()) } }) -- 2.30.2